[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [Xen-devel] [PATCH] xen-mapcache: Fix rlimit set size.
From: |
Stefano Stabellini |
Subject: |
Re: [Qemu-devel] [Xen-devel] [PATCH] xen-mapcache: Fix rlimit set size. |
Date: |
Tue, 2 Aug 2011 23:03:37 +0100 |
User-agent: |
Alpine 2.00 (DEB 1167 2008-08-23) |
On Tue, 2 Aug 2011, Jan Beulich wrote:
> >>> Anthony PERARD 08/01/11 9:27 PM >>>
> >Previously, the address space soft limit was set mcache_max_size. So,
> >before the mcache_max_size was reached by the mapcache, QEMU was killed
> >for overuse of the virtual address space.
> >
> >This patch fix that by setting the soft limit to mcache_max_size + 80MB.
> >I observed that QEMU use 75MB more than max_mcache_size after several
> >empirical tests.
>
> Rather fragile going forward I would say.
Yes, I agree. At the very least we should print a warning if rlimit_max
is too low so that the admin can fix it.
> I there any reason not to set
> the limit to infinity?
We shouldn't assume that qemu is running as a privileged process, but
if it is we should definitely do it.