[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH] do not call monitor_resume() from migrate_fd_put_bu
From: |
Michael Tokarev |
Subject: |
[Qemu-devel] [PATCH] do not call monitor_resume() from migrate_fd_put_buffer() error path |
Date: |
Wed, 3 Aug 2011 18:51:44 +0400 |
If we do, it results in double monitor_resume() (second being called
from migrate_fd_cleanup() anyway) and monitor suspend count becoming
negative.
Signed-Off-By: Michael Tokarev <address@hidden>
Reviewed-By: Jan Kiszka <address@hidden>
---
migration.c | 3 ---
1 files changed, 0 insertions(+), 3 deletions(-)
diff --git a/migration.c b/migration.c
index 2a15b98..7ca883f 100644
--- a/migration.c
+++ b/migration.c
@@ -330,9 +330,6 @@ ssize_t migrate_fd_put_buffer(void *opaque, const void
*data, size_t size)
if (ret == -EAGAIN) {
qemu_set_fd_handler2(s->fd, NULL, NULL, migrate_fd_put_notify, s);
} else if (ret < 0) {
- if (s->mon) {
- monitor_resume(s->mon);
- }
s->state = MIG_STATE_ERROR;
notifier_list_notify(&migration_state_notifiers, NULL);
}
--
1.7.2.5
- [Qemu-devel] [PATCH] do not call monitor_resume() from migrate_fd_put_buffer() error path,
Michael Tokarev <=