[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] Reorganize and fix monitor resume after migrati
|
From: |
Michael Tokarev |
|
Subject: |
Re: [Qemu-devel] [PATCH] Reorganize and fix monitor resume after migration |
|
Date: |
Fri, 05 Aug 2011 11:28:21 +0400 |
|
User-agent: |
Mozilla/5.0 (X11; U; Linux i686 (x86_64); en-US; rv:1.9.1.16) Gecko/20110704 Icedove/3.0.11 |
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
05.08.2011 11:11, Jan Kiszka wrote:
> From: Jan Kiszka <address@hidden>
>
> If migration failed in migrate_fd_put_buffer, the monitor may have been
> resumed not only in the error path of that function but also once again
> in migrate_fd_put_ready which is called unconditionally by
> migrate_fd_connect.
>
> Fix this by establishing a cleaner policy: the monitor shall be resumed
> when the migration file is closed, either via callback
> (migrate_fd_close) or in migrate_fd_cleanup if no file is open (i.e. no
> callback invoked).
>
> Signed-off-by: Jan Kiszka <address@hidden>
Reported-By: Michael Tokarev <address@hidden>
Tested-By: Michael Tokarev <address@hidden>
This is a good candidate for 0.12, 0.14 and 0.15... ;)
Thank you !
/mjt
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)
iJwEAQECAAYFAk47m5UACgkQUlPFrXTwyDgUKAP/ZsVlWiCKmcMhRSItuR6rIT/K
k/JY4FwARVpBdv6zVFPsLX4UgsPbC6QfUsYjgZtWhSaiboyi7rRAj75OEipYjBqu
IWgBXmXwt6ATxsxC7ffrUtO15QXABmaQyYjBGI+EzJZdKPuzjEfm5wFgHr0+epDn
4svPOur4pC6ttDT3Ldc=
=sHNU
-----END PGP SIGNATURE-----