Re: [Qemu-devel] [PATCH] target-arm: upgrade for secondary cpu bootloader

[Evgeny Voevodin]

On 08/05/2011 03:35 PM, Peter Maydell wrote:
> On 5 August 2011 11:37, Evgeny Voevodin<address@hidden>  wrote:
> > Secondary CPU bootloader enables interrupt and issues wfi until start
> > address is written to system controller. The position where to find this
> > start address is hardcoded to 0x10000030. This commit adds new bootloader
> > for secondary CPU which allows a target board to cpecify a position where to
> > find start address.
>
> What's the motivation for this? (ie what target board needs this?)

The motivation is that Samsung s5pc210 board which is under development 
needs this. Also, I believe that more boards will need it in future.

> (Is there a patch 2/2 or is the subject wrong?)

Subject is wrong.

> Also, having a second almost-but-not-quite-identical copy of the
> secondary-cpu bootloader is definitely the wrong approach. If some
> boards need this then we should just have a single smpboot[] bootloader
> which has both privbase and startaddr specified as data members, and
> just have the code which sets it up fill in 0x10000030 if the board
> doesn't override the default.
>
> -- PMM

Will update.