Re: [Qemu-devel] [PATCH 03/16] Add iov_clear()

[Gerd Hoffmann]

On 08/05/11 13:30, Kevin Wolf wrote:
> Am 04.08.2011 17:10, schrieb Gerd Hoffmann:
> > Fill the spefified area with zeros.
> >
> > Signed-off-by: Gerd Hoffmann<address@hidden>
>
> Looks like we're starting to duplicate everything in qemu_iovec_* and
> iov_*...
>
> Any reason not to use QEMUIOVector?

I *do* use QEMUIOVector, but for the actual copy I'm using 
iov_{from,to}_buf() instead of qemu_iovec_{from,to}_buffer because the 
former allows to specify an offset.

But, yea, we have some duplication here, qemu_iovec_* can just call 
iov_* instead of reimplementing stuff ...

cheers,
  Gerd

x
Description: Text document