[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v4 09/39] cirrus: simplify linear framebuffer access
From: |
Avi Kivity |
Subject: |
[Qemu-devel] [PATCH v4 09/39] cirrus: simplify linear framebuffer access functions |
Date: |
Mon, 8 Aug 2011 16:09:02 +0300 |
Make use of the memory API's ability to satisfy multi-byte accesses via
multiple single-byte accesses.
Reviewed-by: Richard Henderson <address@hidden>
Reviewed-by: Anthony Liguori <address@hidden>
Signed-off-by: Avi Kivity <address@hidden>
---
hw/cirrus_vga.c | 74 ++++++-------------------------------------------------
1 files changed, 8 insertions(+), 66 deletions(-)
diff --git a/hw/cirrus_vga.c b/hw/cirrus_vga.c
index 2a9bd25..c9887ac 100644
--- a/hw/cirrus_vga.c
+++ b/hw/cirrus_vga.c
@@ -2250,7 +2250,8 @@ static void cirrus_cursor_draw_line(VGACommonState *s1,
uint8_t *d1, int scr_y)
*
***************************************/
-static uint32_t cirrus_linear_readb(void *opaque, target_phys_addr_t addr)
+static uint64_t cirrus_linear_read(void *opaque, target_phys_addr_t addr,
+ unsigned size)
{
CirrusVGAState *s = opaque;
uint32_t ret;
@@ -2278,28 +2279,8 @@ static uint32_t cirrus_linear_readb(void *opaque,
target_phys_addr_t addr)
return ret;
}
-static uint32_t cirrus_linear_readw(void *opaque, target_phys_addr_t addr)
-{
- uint32_t v;
-
- v = cirrus_linear_readb(opaque, addr);
- v |= cirrus_linear_readb(opaque, addr + 1) << 8;
- return v;
-}
-
-static uint32_t cirrus_linear_readl(void *opaque, target_phys_addr_t addr)
-{
- uint32_t v;
-
- v = cirrus_linear_readb(opaque, addr);
- v |= cirrus_linear_readb(opaque, addr + 1) << 8;
- v |= cirrus_linear_readb(opaque, addr + 2) << 16;
- v |= cirrus_linear_readb(opaque, addr + 3) << 24;
- return v;
-}
-
-static void cirrus_linear_writeb(void *opaque, target_phys_addr_t addr,
- uint32_t val)
+static void cirrus_linear_write(void *opaque, target_phys_addr_t addr,
+ uint64_t val, unsigned size)
{
CirrusVGAState *s = opaque;
unsigned mode;
@@ -2339,49 +2320,6 @@ static void cirrus_linear_writeb(void *opaque,
target_phys_addr_t addr,
}
}
-static void cirrus_linear_writew(void *opaque, target_phys_addr_t addr,
- uint32_t val)
-{
- cirrus_linear_writeb(opaque, addr, val & 0xff);
- cirrus_linear_writeb(opaque, addr + 1, (val >> 8) & 0xff);
-}
-
-static void cirrus_linear_writel(void *opaque, target_phys_addr_t addr,
- uint32_t val)
-{
- cirrus_linear_writeb(opaque, addr, val & 0xff);
- cirrus_linear_writeb(opaque, addr + 1, (val >> 8) & 0xff);
- cirrus_linear_writeb(opaque, addr + 2, (val >> 16) & 0xff);
- cirrus_linear_writeb(opaque, addr + 3, (val >> 24) & 0xff);
-}
-
-
-static uint64_t cirrus_linear_read(void *opaque, target_phys_addr_t addr,
- unsigned size)
-{
- CirrusVGAState *s = opaque;
-
- switch (size) {
- case 1: return cirrus_linear_readb(s, addr);
- case 2: return cirrus_linear_readw(s, addr);
- case 4: return cirrus_linear_readl(s, addr);
- default: abort();
- }
-}
-
-static void cirrus_linear_write(void *opaque, target_phys_addr_t addr,
- uint64_t data, unsigned size)
-{
- CirrusVGAState *s = opaque;
-
- switch (size) {
- case 1: return cirrus_linear_writeb(s, addr, data);
- case 2: return cirrus_linear_writew(s, addr, data);
- case 4: return cirrus_linear_writel(s, addr, data);
- default: abort();
- }
-}
-
/***************************************
*
* system to screen memory access
@@ -2859,6 +2797,10 @@ static const MemoryRegionOps cirrus_linear_io_ops = {
.read = cirrus_linear_read,
.write = cirrus_linear_write,
.endianness = DEVICE_LITTLE_ENDIAN,
+ .impl = {
+ .min_access_size = 1,
+ .max_access_size = 1,
+ },
};
static void cirrus_init_common(CirrusVGAState * s, int device_id, int is_pci)
--
1.7.5.3
- [Qemu-devel] [PATCH v4 12/39] pci: allow I/O BARs to be registered with pci_register_bar_region(), (continued)
- [Qemu-devel] [PATCH v4 12/39] pci: allow I/O BARs to be registered with pci_register_bar_region(), Avi Kivity, 2011/08/08
- [Qemu-devel] [PATCH v4 02/39] pci: add API to get a BAR's mapped address, Avi Kivity, 2011/08/08
- [Qemu-devel] [PATCH v4 35/39] pci: convert pci rom to memory API, Avi Kivity, 2011/08/08
- [Qemu-devel] [PATCH v4 21/39] ahci: convert to memory API, Avi Kivity, 2011/08/08
- [Qemu-devel] [PATCH v4 27/39] i6300esb: convert to memory API, Avi Kivity, 2011/08/08
- [Qemu-devel] [PATCH v4 10/39] Integrate I/O memory regions into qemu, Avi Kivity, 2011/08/08
- [Qemu-devel] [PATCH v4 29/39] sun4u: convert to memory API, Avi Kivity, 2011/08/08
- [Qemu-devel] [PATCH v4 34/39] pci: remove pci_register_bar_simple(), Avi Kivity, 2011/08/08
- [Qemu-devel] [PATCH v4 13/39] rtl8139: convert to memory API, Avi Kivity, 2011/08/08
- [Qemu-devel] [PATCH v4 30/39] ehci: convert to memory API, Avi Kivity, 2011/08/08
- [Qemu-devel] [PATCH v4 09/39] cirrus: simplify linear framebuffer access functions,
Avi Kivity <=
- [Qemu-devel] [PATCH v4 19/39] ivshmem: convert to memory API, Avi Kivity, 2011/08/08
- [Qemu-devel] [PATCH v4 15/39] e1000: convert to memory API, Avi Kivity, 2011/08/08
- [Qemu-devel] [PATCH v4 23/39] lsi53c895a: convert to memory API, Avi Kivity, 2011/08/08
- [Qemu-devel] [PATCH v4 31/39] uhci: convert to memory API, Avi Kivity, 2011/08/08
- [Qemu-devel] [PATCH v4 08/39] vga: simplify vga window mmio access functions, Avi Kivity, 2011/08/08
- [Qemu-devel] [PATCH v4 37/39] pci: fold BAR mapping function into its caller, Avi Kivity, 2011/08/08
- [Qemu-devel] [PATCH v4 32/39] xen-platform: convert to memory API, Avi Kivity, 2011/08/08
- [Qemu-devel] [PATCH v4 14/39] ac97: convert to memory API, Avi Kivity, 2011/08/08