[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v4 29/39] sun4u: convert to memory API
From: |
Avi Kivity |
Subject: |
[Qemu-devel] [PATCH v4 29/39] sun4u: convert to memory API |
Date: |
Mon, 8 Aug 2011 16:09:22 +0300 |
fixes memory leak on repeated BAR map/unmap
Reviewed-by: Richard Henderson <address@hidden>
Signed-off-by: Avi Kivity <address@hidden>
---
hw/sun4u.c | 55 +++++++++++++++++++++++++------------------------------
1 files changed, 25 insertions(+), 30 deletions(-)
diff --git a/hw/sun4u.c b/hw/sun4u.c
index d7dcaf0..cb76031 100644
--- a/hw/sun4u.c
+++ b/hw/sun4u.c
@@ -91,6 +91,12 @@ struct hwdef {
uint64_t console_serial_base;
};
+typedef struct EbusState {
+ PCIDevice pci_dev;
+ MemoryRegion bar0;
+ MemoryRegion bar1;
+} EbusState;
+
int DMA_get_channel_mode (int nchan)
{
return 0;
@@ -518,21 +524,6 @@ void cpu_tick_set_limit(CPUTimer *timer, uint64_t limit)
}
}
-static void ebus_mmio_mapfunc(PCIDevice *pci_dev, int region_num,
- pcibus_t addr, pcibus_t size, int type)
-{
- EBUS_DPRINTF("Mapping region %d registers at %" FMT_PCIBUS "\n",
- region_num, addr);
- switch (region_num) {
- case 0:
- isa_mmio_init(addr, 0x1000000);
- break;
- case 1:
- isa_mmio_init(addr, 0x800000);
- break;
- }
-}
-
static void dummy_isa_irq_handler(void *opaque, int n, int level)
{
}
@@ -549,27 +540,31 @@ pci_ebus_init(PCIBus *bus, int devfn)
}
static int
-pci_ebus_init1(PCIDevice *s)
+pci_ebus_init1(PCIDevice *pci_dev)
{
- isa_bus_new(&s->qdev);
+ EbusState *s = DO_UPCAST(EbusState, pci_dev, pci_dev);
+
+ isa_bus_new(&pci_dev->qdev);
- s->config[0x04] = 0x06; // command = bus master, pci mem
- s->config[0x05] = 0x00;
- s->config[0x06] = 0xa0; // status = fast back-to-back, 66MHz, no error
- s->config[0x07] = 0x03; // status = medium devsel
- s->config[0x09] = 0x00; // programming i/f
- s->config[0x0D] = 0x0a; // latency_timer
+ pci_dev->config[0x04] = 0x06; // command = bus master, pci mem
+ pci_dev->config[0x05] = 0x00;
+ pci_dev->config[0x06] = 0xa0; // status = fast back-to-back, 66MHz, no
error
+ pci_dev->config[0x07] = 0x03; // status = medium devsel
+ pci_dev->config[0x09] = 0x00; // programming i/f
+ pci_dev->config[0x0D] = 0x0a; // latency_timer
- pci_register_bar(s, 0, 0x1000000, PCI_BASE_ADDRESS_SPACE_MEMORY,
- ebus_mmio_mapfunc);
- pci_register_bar(s, 1, 0x800000, PCI_BASE_ADDRESS_SPACE_MEMORY,
- ebus_mmio_mapfunc);
+ isa_mmio_setup(&s->bar0, 0x1000000);
+ pci_register_bar_region(pci_dev, 0, PCI_BASE_ADDRESS_SPACE_MEMORY,
+ &s->bar0);
+ isa_mmio_setup(&s->bar1, 0x800000);
+ pci_register_bar_region(pci_dev, 1, PCI_BASE_ADDRESS_SPACE_MEMORY,
+ &s->bar1);
return 0;
}
static PCIDeviceInfo ebus_info = {
.qdev.name = "ebus",
- .qdev.size = sizeof(PCIDevice),
+ .qdev.size = sizeof(EbusState),
.init = pci_ebus_init1,
.vendor_id = PCI_VENDOR_ID_SUN,
.device_id = PCI_DEVICE_ID_SUN_EBUS,
--
1.7.5.3
- Re: [Qemu-devel] [PATCH v4 26/39] pcnet: convert to memory API, (continued)
[Qemu-devel] [PATCH v4 05/39] cirrus: simplify mmio BAR access functions, Avi Kivity, 2011/08/08
[Qemu-devel] [PATCH v4 12/39] pci: allow I/O BARs to be registered with pci_register_bar_region(), Avi Kivity, 2011/08/08
[Qemu-devel] [PATCH v4 02/39] pci: add API to get a BAR's mapped address, Avi Kivity, 2011/08/08
[Qemu-devel] [PATCH v4 35/39] pci: convert pci rom to memory API, Avi Kivity, 2011/08/08
[Qemu-devel] [PATCH v4 21/39] ahci: convert to memory API, Avi Kivity, 2011/08/08
[Qemu-devel] [PATCH v4 27/39] i6300esb: convert to memory API, Avi Kivity, 2011/08/08
[Qemu-devel] [PATCH v4 10/39] Integrate I/O memory regions into qemu, Avi Kivity, 2011/08/08
[Qemu-devel] [PATCH v4 29/39] sun4u: convert to memory API,
Avi Kivity <=
[Qemu-devel] [PATCH v4 34/39] pci: remove pci_register_bar_simple(), Avi Kivity, 2011/08/08
[Qemu-devel] [PATCH v4 13/39] rtl8139: convert to memory API, Avi Kivity, 2011/08/08
[Qemu-devel] [PATCH v4 30/39] ehci: convert to memory API, Avi Kivity, 2011/08/08
[Qemu-devel] [PATCH v4 09/39] cirrus: simplify linear framebuffer access functions, Avi Kivity, 2011/08/08
[Qemu-devel] [PATCH v4 19/39] ivshmem: convert to memory API, Avi Kivity, 2011/08/08
[Qemu-devel] [PATCH v4 15/39] e1000: convert to memory API, Avi Kivity, 2011/08/08
[Qemu-devel] [PATCH v4 23/39] lsi53c895a: convert to memory API, Avi Kivity, 2011/08/08
[Qemu-devel] [PATCH v4 31/39] uhci: convert to memory API, Avi Kivity, 2011/08/08