Re: [Qemu-devel] [PATCH 09/24] omap_gpmc/nseries/tusb6010: convert to memory API

[Avi Kivity]

On 08/09/2011 11:44 AM, Avi Kivity wrote:
> > ...isn't this just throwing away the warnings on bad-width accesses?
>
>
> It is; will fix.

Reading the original code, it seems broken:

uint32_t omap_badwidth_read32(void *opaque, target_phys_addr_t addr)
{
    uint32_t ret;

    OMAP_32B_REG(addr);
    cpu_physical_memory_read(addr, (void *) &ret, 4);
    return ret;
}

The code issues a read from addr, but that is not the original address 
used by the guest, since addresses are relative to the start of the 
region (in both the old and new APIs), not to physical address start.

So I'll just set access size validity in the new code.

--
error compiling committee.c: too many arguments to function