qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] e1000: Do reset when E1000_CTRL_RST bit is set.


From: Peter Maydell
Subject: Re: [Qemu-devel] [PATCH] e1000: Do reset when E1000_CTRL_RST bit is set.
Date: Tue, 9 Aug 2011 18:10:08 +0100

On 9 August 2011 15:10, Anthony PERARD <address@hidden> wrote:
> On Fri, Aug 5, 2011 at 17:53, Anthony Liguori <address@hidden> wrote:
>>
>> You'll break some GCCs with -Wall -Werror with this.  Please do:
>>
>> if ((val & E1000_CTRL_RST)) {
>
> :(, I never heard of this. But OK, I will do that.

Please don't unless Anthony L can actually demonstrate a compiler
which has this property and doesn't already complain about all
the existing equivalent code in qemu...

-- PMM



reply via email to

[Prev in Thread] Current Thread [Next in Thread]