Re: [Qemu-devel] [PATCH 1/4] hid: register kbd hander in init()

[Peter Maydell]

On 9 August 2011 22:54, Michael Walle <address@hidden> wrote:
> Register the keyboard event handler in hid's init() instead of its reset()
> function.
>
> Signed-off-by: Michael Walle <address@hidden>

Reviewed-by: Peter Maydell <address@hidden>

There's actually an equivalent patch to this lurking in the
qemu-linaro patch stack (inherited from the meego tree).

If we fix qemu_add_kbd_event_handler() so that it actually
lets you register more than one keyboard at once (as you
can with mice) then this is definitely required, otherwise
the USB keyboard reregisters itself every time there's a
USB reset, and you get key duplication.
(There's a meego patch to add the multiple-keyboard support:
http://git.linaro.org/gitweb?p=qemu/qemu-linaro.git;a=commitdiff;h=41fc7075cfd74524acc2db73a48534e6bfbea8c4
but that's still in my "to clean up" list so it contains some
changes which should be in a separate patch.)

-- PMM