qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH STABLE] build: Move QEMU_INCLUDES before QEMU_CF


From: Avi Kivity
Subject: Re: [Qemu-devel] [PATCH STABLE] build: Move QEMU_INCLUDES before QEMU_CFLAGS
Date: Wed, 10 Aug 2011 17:08:42 +0300
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:5.0) Gecko/20110707 Thunderbird/5.0

On 08/10/2011 05:02 PM, Jiri Denemark wrote:
>
>  Shouldn't we use -isystem instead of -I for system headers?

That would be ideal but unfortunately QEMU_CFLAGS also contains output of
pkg-config --cflags which uses -I for header paths. We would need to convert
them to -isystem. And is -isystem even portable to other compilers (in case we
care about that)?

Well, it's really a pkg-config bug. It should check whether -isystem is supported and use it if so.

IMHO just moving paths to qemu sources first is easier and the result is the
same.


Agree.

--
error compiling committee.c: too many arguments to function




reply via email to

[Prev in Thread] Current Thread [Next in Thread]