[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 10/11] memory: Fix old_portio vs non-zero offset.
From: |
Richard Henderson |
Subject: |
[Qemu-devel] [PATCH 10/11] memory: Fix old_portio vs non-zero offset. |
Date: |
Wed, 10 Aug 2011 15:28:19 -0700 |
The legacy functions that we're wrapping expect that offset
to be included in the register. Indeed, they generally
expect the absolute address and then mask off the "high" bits.
The FDC is the first converted device with a non-zero offset.
Signed-off-by: Richard Henderson <address@hidden>
---
memory.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/memory.c b/memory.c
index a1f118b..2c82cd3 100644
--- a/memory.c
+++ b/memory.c
@@ -367,7 +367,7 @@ static void memory_region_iorange_read(IORange *iorange,
*data = ((uint64_t)1 << (width * 8)) - 1;
if (mrp) {
- *data = mrp->read(mr->opaque, offset - mrp->offset);
+ *data = mrp->read(mr->opaque, offset);
}
return;
}
@@ -391,7 +391,7 @@ static void memory_region_iorange_write(IORange *iorange,
const MemoryRegionPortio *mrp = find_portio(mr, offset, width, true);
if (mrp) {
- mrp->write(mr->opaque, offset - mrp->offset, data);
+ mrp->write(mr->opaque, offset, data);
}
return;
}
--
1.7.6
- [Qemu-devel] [PATCH 05/11] cs4231a: Convert to MemoryRegion., (continued)
- [Qemu-devel] [PATCH 05/11] cs4231a: Convert to MemoryRegion., Richard Henderson, 2011/08/10
- [Qemu-devel] [PATCH 06/11] i8254: Convert to MemoryRegion., Richard Henderson, 2011/08/10
- [Qemu-devel] [PATCH 01/11] pci: add pci_address_space_io(), Richard Henderson, 2011/08/10
- [Qemu-devel] [PATCH 07/11] i8259: Convert to MemoryRegion., Richard Henderson, 2011/08/10
- [Qemu-devel] [PATCH 08/11] pckbd: Convert to MemoryRegion., Richard Henderson, 2011/08/10
- [Qemu-devel] [PATCH 09/11] serial: Convert serial_isa_initfn to MemoryRegion., Richard Henderson, 2011/08/10
- [Qemu-devel] [PATCH 11/11] fdc: Convert isabus_fdc_init1 to MemoryRegion., Richard Henderson, 2011/08/10
- [Qemu-devel] [PATCH 10/11] memory: Fix old_portio vs non-zero offset.,
Richard Henderson <=
- Re: [Qemu-devel] [PATCH 00/11] Memory API conversion for ISA, Avi Kivity, 2011/08/11
- Re: [Qemu-devel] [PATCH 00/11] Memory API conversion for ISA, Richard Henderson, 2011/08/11