Re: [Qemu-devel] [PATCH 18/24] versatile_pci: convert to memory API

[Peter Maydell]

On 8 August 2011 18:07, Avi Kivity <address@hidden> wrote:
> -static uint32_t pci_vpb_config_readb (void *opaque, target_phys_addr_t addr)
> +static uint64_t pci_vpb_config_read(void *opaque, target_phys_addr_t addr,
> +                                    unsigned size)
>  {
>     uint32_t val;
> -    val = pci_data_read(opaque, vpb_pci_config_addr (addr), 1);
> -    return val;
> +    val = pci_data_read(opaque, vpb_pci_config_addr(addr), size);
> +    return size;
>  }

This should be 'return val', not 'return size', I think...
(otherwise PCI is broken on versatilepb; tested with your memory-region
branch rather than with this particular patch.)

-- PMM