|
From: | Anthony Liguori |
Subject: | Re: [Qemu-devel] [PATCH 2/3] memory: add API for creating ROM/device regions |
Date: | Fri, 12 Aug 2011 08:48:24 -0500 |
User-agent: | Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.17) Gecko/20110516 Lightning/1.0b2 Thunderbird/3.1.10 |
On 08/08/2011 11:58 AM, Avi Kivity wrote:
ROM/device regions act as mapped RAM for reads, can I/O memory for writes. This allow emulation of flash devices. Signed-off-by: Avi Kivity<address@hidden> --- memory.c | 46 ++++++++++++++++++++++++++++++++++++++++++++-- memory.h | 34 ++++++++++++++++++++++++++++++++++ 2 files changed, 78 insertions(+), 2 deletions(-) diff --git a/memory.c b/memory.c index 5e3d966..beff98c 100644 --- a/memory.c +++ b/memory.c @@ -125,6 +125,7 @@ struct FlatRange { target_phys_addr_t offset_in_region; AddrRange addr; uint8_t dirty_log_mask; + bool readable;
In a follow up, it might be good to add a comment explaining that this whole readable thing is not just an optimization, but a hard requirement for KVM in order to be able to execute code from ROM.
Regards, Anthony Liguori
[Prev in Thread] | Current Thread | [Next in Thread] |