qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 1/5] qemu-char: make qemu_chr_event public


From: Anthony Liguori
Subject: Re: [Qemu-devel] [PATCH 1/5] qemu-char: make qemu_chr_event public
Date: Fri, 12 Aug 2011 08:57:33 -0500
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.17) Gecko/20110516 Lightning/1.0b2 Thunderbird/3.1.10

On 08/11/2011 07:25 AM, Hans de Goede wrote:
Make qemu_chr_event public so that it can be used by chardev code
which lives outside of qemu-char.c

Normally, qemu_chr_generic_open() would be used to do this. Of course, there is no generic_close().

Are you sure you don't need the BH indirection?

Regards,

Anthony Liguori


Signed-off-by: Hans de Goede<address@hidden>
---
  qemu-char.c |    2 +-
  qemu-char.h |    1 +
  2 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/qemu-char.c b/qemu-char.c
index 8d39500..5d5a6d5 100644
--- a/qemu-char.c
+++ b/qemu-char.c
@@ -119,7 +119,7 @@ static void char_write_unblocked(void *opaque)
      chr->chr_write_unblocked(chr->handler_opaque);
  }

-static void qemu_chr_event(CharDriverState *s, int event)
+void qemu_chr_event(CharDriverState *s, int event)
  {
      /* Keep track if the char device is open */
      switch (event) {
diff --git a/qemu-char.h b/qemu-char.h
index 68e7b5b..77ad62d 100644
--- a/qemu-char.h
+++ b/qemu-char.h
@@ -107,6 +107,7 @@ int qemu_chr_ioctl(CharDriverState *s, int cmd, void *arg);
  void qemu_chr_generic_open(CharDriverState *s);
  int qemu_chr_can_read(CharDriverState *s);
  void qemu_chr_read(CharDriverState *s, uint8_t *buf, int len);
+void qemu_chr_event(CharDriverState *s, int event);
  int qemu_chr_get_msgfd(CharDriverState *s);
  void qemu_chr_accept_input(CharDriverState *s);
  int qemu_chr_add_client(CharDriverState *s, int fd);




reply via email to

[Prev in Thread] Current Thread [Next in Thread]