Re: [Qemu-devel] New patches for w32, w64

[Blue Swirl]

On Sat, Aug 13, 2011 at 9:38 AM, Stefan Weil <address@hidden> wrote:
> Am 15.07.2011 21:38, schrieb Stefan Weil:
>>
>> Here are some small patches needed for the w32 and w64 platforms.
>>
>> [PATCH 1/3] Fix conversions from pointer to tcg_target_long
>> [PATCH 2/3] w64: Add definition of FMT_pid
>> [PATCH 3/3] w32: Fix format string regression
>>
>> Kind regards,
>> Stefan
>
> What about these patches?
>
> Patch 1 was acked by two developers:
>    http://patchwork.ozlabs.org/patch/104889/
>
> Patch 2 was review by Andreas:
>    http://patchwork.ozlabs.org/patch/104884/
>
> Patch 3 was discussed a lot:
>    http://patchwork.ozlabs.org/patch/104885/
>
> At least the first two patches can be applied immediately.

Yes.

> I also think that the third patch is correct and should be applied.
> It's only MinGW related and fixes a compiler error (regression) there.

The interfaces are broken in so many ways that I don't know what is
the right fix, maybe introducing qemu_getpid() which always returned
pid_t could hide this madness. Then 3/3 would not be needed.