Re: [Qemu-devel] [PATCH 0/8] *** SUBJECT HERE ***

[Laurent Vivier]

Bryce,

 

please, run scripts/checkpatch.pl before submitting them to check the style.

Then, IMHO, you can put all next-cube stuff in one patch (hw/next-* + Makefile.target),

then make one patch by m68k feature/instruction added or m68k default corrected.

 

And remember, to be able to bisect, each patch must be able to be compiled and run.

 

Good Luck,

Laurent

 

Le 18 août 2011 à 00:09, Bryce Lanham <address@hidden> a écrit :

> *** BLURB HERE ***
>
> Bryce Lanham (8):
>   added next source files to Makefile.target
>   main next driver, needs a bit of cleanup
>   next framebuffer driver, very basic, only supports running under 32
>     bit color at the moment
>   next keyboard driver, only supports a subset of modifier keys
>   partially working network driver, needs more comparison with real
>     hardware before it can be made fully working
>   adds SFC, DFC, MMU TC, access control register, and user stack
>     pointer acces to movec_to/from
>   added move16, cinva, pflush instructions, and disabled abort on
>     execution of frestore/fsave
>   added mmu tc, sfc, dfc, and access control registers to the cpu
>     header
>
>  Makefile.target         |    2 +
>  hw/next-cube.c          |  471 +++++++++++++++++++++++++++++++++++++++++++
>  hw/next-fb.c            |  102 ++++++++++
>  hw/next-fb.h            |   14 ++
>  hw/next-kbd.c           |  243 ++++++++++++++++++++++
>  hw/next-kbd.h           |    2 +
>  hw/next-net.c           |  513 +++++++++++++++++++++++++++++++++++++++++++++++
>  hw/next-net.h           |    2 +
>  target-m68k/cpu.h       |   12 +-
>  target-m68k/helper.c    |   44 ++++-
>  target-m68k/translate.c |  108 +++++++++-
>  11 files changed, 1491 insertions(+), 22 deletions(-)
>  create mode 100644 hw/next-cube.c
>  create mode 100644 hw/next-fb.c
>  create mode 100644 hw/next-fb.h
>  create mode 100644 hw/next-kbd.c
>  create mode 100644 hw/next-kbd.h
>  create mode 100644 hw/next-net.c
>  create mode 100644 hw/next-net.h
>
> --
> 1.7.2.3
>
>