[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC 6/6] isa: improve bus implementation of ebus bridg
From: |
Richard Henderson |
Subject: |
Re: [Qemu-devel] [RFC 6/6] isa: improve bus implementation of ebus bridge |
Date: |
Sat, 20 Aug 2011 13:12:04 -0700 |
User-agent: |
Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.18) Gecko/20110621 Fedora/3.1.11-1.fc14 Thunderbird/3.1.11 |
On 08/20/2011 07:56 AM, Hervé Poussineau wrote:
> + memory_region_init(&s->isa_mem_space, "isa-memory", 0x00100000);
> + memory_region_add_subregion(get_system_memory(),
> + APB_PCI_IO_BASE,
> + &s->isa_mem_space);
You should be passing on, or adding this subregion to, the PCI
memory region. Unfortunately, apb_pci.c hasn't been converted
to the new api yet...
r~
- [Qemu-devel] [RFC 0/6] ISA bus improvements, Hervé Poussineau, 2011/08/20
- [Qemu-devel] [RFC 1/6] isa: rename isa_bus_new to isa_bus_bridge_init, Hervé Poussineau, 2011/08/20
- [Qemu-devel] [RFC 2/6] isa: rework ISA bus internals, and add ISA bus ops structure, Hervé Poussineau, 2011/08/20
- [Qemu-devel] [RFC 3/6] isa: add isa_address_space() method, Hervé Poussineau, 2011/08/20
- [Qemu-devel] [RFC 4/6] vga: use isa_address_space() method, Hervé Poussineau, 2011/08/20
- [Qemu-devel] [RFC 6/6] isa: improve bus implementation of ebus bridge, Hervé Poussineau, 2011/08/20
- Re: [Qemu-devel] [RFC 6/6] isa: improve bus implementation of ebus bridge,
Richard Henderson <=
- [Qemu-devel] [RFC 5/6] isa: improve bus implementation of PIIX3 bridge, Hervé Poussineau, 2011/08/20