Re: [Qemu-devel] [PATCH 0/6] TCG compile fixes and optimize cleanup

[Blue Swirl]

Thanks, applied 1 to 5.

On Wed, Aug 17, 2011 at 9:11 PM, Richard Henderson <address@hidden> wrote:
> As discussed elsewhere, one way to tidy up tcg/optimize.c
> is to always provide the enum names, even if the host does
> not support the operation.
>
> As a sanity check, I wanted to include a test to make sure
> that we never tried to output an opcode that the target
> does not handle.  I did this via a bit in the TCGOpDef flags.
> In order to get that set, I changed all of the TCG_TARGET_HAS*
> macros to be true/false rather than def/undef.
>
> That allowed a further cleanup to change ifdefs into C IFs.
>
> Unfortunately, it wasn't really possible to split this into
> smaller pieces.  Using the C IFs requires the enums be
> present, even if unused.
>
> I cross-compiled --target-list=i386-softmmu,i386-linux-user
> for each of the tcg hosts.  In the process I discovered a
> number of pure compilation errors.
>
>
> r~
>
>
> Richard Henderson (6):
>  tcg: Add and use TCG_OPF_64BIT.
>  tcg: Always define all of the TCGOpcode enum members.
>  tcg: Constant fold neg, andc, orc, eqv, nand, nor.
>  tcg-hppa: Fix CPU_TEMP_BUF_NLONGS oversight.
>  tcg-ia64: Fix typos in AREG0 setup in prologue.
>  tcg-arm: Make tcg_out_addi inline
>
>  tcg/arm/tcg-target.c   |    2 +-
>  tcg/arm/tcg-target.h   |   30 +-
>  tcg/hppa/tcg-target.c  |    2 +-
>  tcg/hppa/tcg-target.h  |   29 +-
>  tcg/i386/tcg-target.h  |   68 ++--
>  tcg/ia64/tcg-target.c  |    4 +-
>  tcg/ia64/tcg-target.h  |   66 ++--
>  tcg/mips/tcg-target.h  |   31 +-
>  tcg/optimize.c         |  260 +++-----------
>  tcg/ppc/tcg-target.h   |   31 +-
>  tcg/ppc64/tcg-target.h |   68 ++--
>  tcg/s390/tcg-target.h  |   68 ++--
>  tcg/sparc/tcg-target.h |   68 ++--
>  tcg/tcg-op.h           |  946 
> +++++++++++++++++++++++-------------------------
>  tcg/tcg-opc.h          |  242 +++++--------
>  tcg/tcg.c              |    6 +-
>  tcg/tcg.h              |   59 +++-
>  17 files changed, 886 insertions(+), 1094 deletions(-)
>
> --
> 1.7.4.4
>
>
>