Re: [Qemu-devel] [PATCH 06/11] Goldfish: Added a nand controller.

[Stefan Hajnoczi]

On Mon, Aug 22, 2011 at 10:39 AM, Patrick Jackson
<address@hidden> wrote:
>
> The paths to the system images must be specified from the command line as
> follows.
> -global goldfish_nand.system_init_path=/path/to/initial/system/image -global
> goldfish_nand.user_data_path=/path/to/user/data
> Signed-off-by: Patrick Jackson <address@hidden>
> ---
>  Makefile.target        |    2 +-
>  hw/android_arm.c       |    2 +
>  hw/goldfish_device.c   | 1398
> ++++++++++++++++++++++++++++++++++++++++++++++++
>  hw/goldfish_device.h   |  205 +++++++
>  hw/goldfish_nand.c     |  914 +++++++++++++++++++++++++++++++
>  hw/goldfish_nand.h     |   29 +
>  hw/goldfish_nand_reg.h |   54 ++
>  7 files changed, 2603 insertions(+), 1 deletions(-)
>  create mode 100644 hw/goldfish_nand.c
>  create mode 100644 hw/goldfish_nand.h
>  create mode 100644 hw/goldfish_nand_reg.h

Please use the block layer instead of reinventing portable file I/O.

Also, please check which of the utility functions already exist in
QEMU.  If a utility function in this patch is needed it should be made
generic for all of QEMU, not just goldfish or nand.

Stefan