[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v3 4/6] vmware-vga: Eliminate vga_dirty_log_restart
From: |
Jan Kiszka |
Subject: |
[Qemu-devel] [PATCH v3 4/6] vmware-vga: Eliminate vga_dirty_log_restart |
Date: |
Mon, 22 Aug 2011 19:12:11 +0200 |
After the conversion to the new Memory API, vga_dirty_log_restart became
seriously pointless. Remove it from vmware-vga and and then finally drop
the service.
CC: Andrzej Zaborowski <address@hidden>
CC: Avi Kivity <address@hidden>
Signed-off-by: Jan Kiszka <address@hidden>
---
hw/vga.c | 6 ------
hw/vga_int.h | 1 -
hw/vmware_vga.c | 2 --
3 files changed, 0 insertions(+), 9 deletions(-)
diff --git a/hw/vga.c b/hw/vga.c
index b0371d5..432d2cb 100644
--- a/hw/vga.c
+++ b/hw/vga.c
@@ -1532,12 +1532,6 @@ void vga_dirty_log_stop(VGACommonState *s)
memory_region_set_log(&s->vram, false, DIRTY_MEMORY_VGA);
}
-void vga_dirty_log_restart(VGACommonState *s)
-{
- vga_dirty_log_stop(s);
- vga_dirty_log_start(s);
-}
-
/*
* graphic modes
*/
diff --git a/hw/vga_int.h b/hw/vga_int.h
index 7e4ed71..d2dd7dd 100644
--- a/hw/vga_int.h
+++ b/hw/vga_int.h
@@ -193,7 +193,6 @@ void vga_common_reset(VGACommonState *s);
void vga_dirty_log_start(VGACommonState *s);
void vga_dirty_log_stop(VGACommonState *s);
-void vga_dirty_log_restart(VGACommonState *s);
extern const VMStateDescription vmstate_vga_common;
uint32_t vga_ioport_read(void *opaque, uint32_t addr);
diff --git a/hw/vmware_vga.c b/hw/vmware_vga.c
index 95c9897..52d2d26 100644
--- a/hw/vmware_vga.c
+++ b/hw/vmware_vga.c
@@ -1175,8 +1175,6 @@ static int pci_vmsvga_initfn(PCIDevice *dev)
iomem = &s->chip.vga.vram;
- vga_dirty_log_restart(&s->chip.vga);
-
s->card.config[PCI_CACHE_LINE_SIZE] = 0x08; /* Cache line
size */
s->card.config[PCI_LATENCY_TIMER] = 0x40; /* Latency timer */
s->card.config[PCI_INTERRUPT_LINE] = 0xff; /* End */
--
1.7.3.4
- [Qemu-devel] [PATCH v3 6/6] vga: Drop some unused fields, (continued)
- [Qemu-devel] [PATCH v3 6/6] vga: Drop some unused fields, Jan Kiszka, 2011/08/22
- [Qemu-devel] [PATCH v3 5/6] vga: Use linear mapping + dirty logging in chain 4 memory access mode, Jan Kiszka, 2011/08/22
- Re: [Qemu-devel] [PATCH v3 5/6] vga: Use linear mapping + dirty logging in chain 4 memory access mode, Avi Kivity, 2011/08/25
- Re: [Qemu-devel] [PATCH v3 5/6] vga: Use linear mapping + dirty logging in chain 4 memory access mode, Jan Kiszka, 2011/08/25
- Re: [Qemu-devel] [PATCH v3 5/6] vga: Use linear mapping + dirty logging in chain 4 memory access mode, Avi Kivity, 2011/08/25
- Re: [Qemu-devel] [PATCH v3 5/6] vga: Use linear mapping + dirty logging in chain 4 memory access mode, Jan Kiszka, 2011/08/25
- Re: [Qemu-devel] [PATCH v3 5/6] vga: Use linear mapping + dirty logging in chain 4 memory access mode, Avi Kivity, 2011/08/25
- Re: [Qemu-devel] [PATCH v3 5/6] vga: Use linear mapping + dirty logging in chain 4 memory access mode, Jan Kiszka, 2011/08/25
- Re: [Qemu-devel] [PATCH v3 5/6] vga: Use linear mapping + dirty logging in chain 4 memory access mode, Avi Kivity, 2011/08/25
- Re: [Qemu-devel] [PATCH v3 5/6] vga: Use linear mapping + dirty logging in chain 4 memory access mode, Jan Kiszka, 2011/08/25
[Qemu-devel] [PATCH v3 4/6] vmware-vga: Eliminate vga_dirty_log_restart,
Jan Kiszka <=
Re: [Qemu-devel] [PATCH v3 0/6] vga: dirty log cleanup, more linear mapping, Anthony Liguori, 2011/08/22