Re: [Qemu-devel] [PATCH 2/2] Added target to build libvdisk

[Anthony Liguori]

On 08/22/2011 12:06 PM, Saggi Mizrahi wrote:
> libvdisk is a library that packages qemu's handling of disk images. This
> allows for other programs to link to it and get access to qemu image
> file abstractions.
>
> To use install the lib and #include<vdisk/block.h>
> all the bdrv_* functions work as expected.
>
> Signed-off-by: Saggi Mizrahi<address@hidden>

It's a good idea in principle but the approach is far too naive.

The block layer needs a good bit of modularization first.  Test cases 
need to be written, and most importantly, using the library shouldn't 
require writing a bunch of dummy functions.

Regards,

Anthony Liguori

> ---
>   .gitignore    |    4 ++--
>   Makefile.objs |    9 +++++++++
>   2 files changed, 11 insertions(+), 2 deletions(-)
>
> diff --git a/.gitignore b/.gitignore
> index 59c343c..a389059 100644
> --- a/.gitignore
> +++ b/.gitignore
> @@ -1,5 +1,4 @@
> -config-devices.*
> -config-all-devices.*
> +config-devices.* config-all-devices.*
>   config-host.*
>   config-target.*
>   trace.h
> @@ -15,6 +14,7 @@ libdis*
>   libhw32
>   libhw64
>   libuser
> +libvdisk
>   qapi-generated
>   qemu-doc.html
>   qemu-tech.html
> diff --git a/Makefile.objs b/Makefile.objs
> index 432b619..291f194 100644
> --- a/Makefile.objs
> +++ b/Makefile.objs
> @@ -171,6 +171,15 @@ common-obj-$(CONFIG_XEN_BACKEND) += xen_backend.o 
> xen_devconfig.o
>   common-obj-$(CONFIG_XEN_BACKEND) += xen_console.o xenfb.o xen_disk.o xen_nic.o
>
>   ######################################################################
> +# libvdisk
> +
> +vdisk-obj-y = $(block-obj-y)
> +
> +vdisk-obj-y += qemu-tool.o qemu-error.o
> +vdisk-obj-y += $(oslib-obj-y) $(trace-obj-y) $(block-obj-y)
> +vdisk-obj-y += $(qobject-obj-y) $(version-obj-y) qemu-timer-common.o
> +
> +######################################################################
>   # libuser
>
>   user-obj-y =