qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 00/16] isa_register_portio_list, v2


From: Avi Kivity
Subject: Re: [Qemu-devel] [PATCH 00/16] isa_register_portio_list, v2
Date: Wed, 24 Aug 2011 12:18:10 +0300
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:6.0) Gecko/20110816 Thunderbird/6.0

On 08/24/2011 03:13 AM, Richard Henderson wrote:
The problem that malc saw with sb16 was a major think-o on my part
with the whole interface.  We can't re-use the const sub-arrays of
the original MemoryRegionPortio array because they have the wrong
offset for the MemoryRegion to which it is attached -- the lookup
in find_portio fails.  We must adjust the offsets of the old_portio
array to be based against the MemoryRegion.

Which means we can easily eliminate the major complaint that came
with the previous round of comments -- the double PORTIO_END_OF_LIST
and the explicit marking of the ranges.  All we require of users
is that the array be sorted by offset.

The entire patch set is at

   git://repo.or.cz/qemu/rth.git mem-api-isa

and is of course based on

   git://git.kernel.org/pub/scm/virt/kvm/qemu-kvm.git memory/master

Avi, the first two patches are fixes for compile errors in your
tree.  They probably ought to be squashed when next you rebase.

Sloppy of me...

The patchset looks good, I'll leave it on the list for a few days before pulling to allow further review.

Once we're done with the conversion, we should look at extending the idea to mmio registers - decode the registers in the core instead of a per-region switch statement.

--
I have a truly marvellous patch that fixes the bug which this
signature is too narrow to contain.




reply via email to

[Prev in Thread] Current Thread [Next in Thread]