[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 00/16] isa_register_portio_list, v2
From: |
malc |
Subject: |
Re: [Qemu-devel] [PATCH 00/16] isa_register_portio_list, v2 |
Date: |
Wed, 24 Aug 2011 13:35:18 +0400 (MSD) |
User-agent: |
Alpine 2.00 (LNX 1167 2008-08-23) |
On Tue, 23 Aug 2011, Richard Henderson wrote:
> The problem that malc saw with sb16 was a major think-o on my part
> with the whole interface. We can't re-use the const sub-arrays of
> the original MemoryRegionPortio array because they have the wrong
> offset for the MemoryRegion to which it is attached -- the lookup
> in find_portio fails. We must adjust the offsets of the old_portio
> array to be based against the MemoryRegion.
>
> Which means we can easily eliminate the major complaint that came
> with the previous round of comments -- the double PORTIO_END_OF_LIST
> and the explicit marking of the ranges. All we require of users
> is that the array be sorted by offset.
>
> The entire patch set is at
>
> git://repo.or.cz/qemu/rth.git mem-api-isa
>
> and is of course based on
>
> git://git.kernel.org/pub/scm/virt/kvm/qemu-kvm.git memory/master
>
> Avi, the first two patches are fixes for compile errors in your
> tree. They probably ought to be squashed when next you rebase.
>
> Malc, I tested sb16 vs the xtc-play you provided. However I failed
> to test the gus changes; the xtc-play program could not recognize
> the device with "--device gus" before or after the patch set.
> Should I be using another set of command-line options for that?
>
I guess xtc can't live without environment variable which tells it
where gus is located `set ULTRASND=240,3,3,7,7'. Anyhow i've tested
things and both sb16 and gus work, thanks.
--
mailto:address@hidden
- [Qemu-devel] [PATCH 09/16] ne2000: Convert to isa_register_ioport., (continued)
- [Qemu-devel] [PATCH 09/16] ne2000: Convert to isa_register_ioport., Richard Henderson, 2011/08/23
- [Qemu-devel] [PATCH 10/16] parallel: Convert to isa_register_portio_list., Richard Henderson, 2011/08/23
- [Qemu-devel] [PATCH 11/16] sb16: Convert to isa_register_portio_list., Richard Henderson, 2011/08/23
- [Qemu-devel] [PATCH 08/16] rtc: Convert to isa_register_ioport., Richard Henderson, 2011/08/23
- [Qemu-devel] [PATCH 13/16] pc: Convert port92 to isa_register_ioport., Richard Henderson, 2011/08/23
- [Qemu-devel] [PATCH 12/16] vga: Convert to isa_register_portio_list., Richard Henderson, 2011/08/23
- [Qemu-devel] [PATCH 15/16] ide: Convert to isa_register_portio_list., Richard Henderson, 2011/08/23
- [Qemu-devel] [PATCH 16/16] isa: Remove isa_init_ioport_range and isa_init_ioport., Richard Henderson, 2011/08/23
- [Qemu-devel] [PATCH 14/16] vmport: Convert to isa_register_ioport., Richard Henderson, 2011/08/23
- Re: [Qemu-devel] [PATCH 00/16] isa_register_portio_list, v2, Avi Kivity, 2011/08/24
- Re: [Qemu-devel] [PATCH 00/16] isa_register_portio_list, v2,
malc <=