[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 06/24] QEMUMachine: pass address space to machin
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] [PATCH 06/24] QEMUMachine: pass address space to machine init function |
Date: |
Wed, 24 Aug 2011 11:32:55 +0100 |
On 24 August 2011 11:11, Avi Kivity <address@hidden> wrote:
> Avoids get_system_memory() everywhere.
> - machine->init(ram_size, boot_devices,
> + machine->init(get_system_memory(), get_system_io(), ram_size,
> boot_devices,
> kernel_filename, kernel_cmdline, initrd_filename,
> cpu_model);
I think this is conceptually wrong. The system memory/IO address spaces
are not configurable properties of the machine model (in the way that
the other arguments to machine->init() are), they're purely an internal
implementation detail of it. (In fact for many of the machines we support
there isn't even any such thing as the system IO space...)
-- PMM
- Re: [Qemu-devel] [PATCH 21/24] mcf5208: convert to memory API, (continued)
[Qemu-devel] [PATCH 07/24] an5206: convert to memory API, Avi Kivity, 2011/08/24
[Qemu-devel] [PATCH 03/24] sysbus: add helpers to add and delete memory regions to the system bus, Avi Kivity, 2011/08/24
[Qemu-devel] [PATCH 13/24] cirrus: wrap memory update in a transaction, Avi Kivity, 2011/08/24
[Qemu-devel] [PATCH 12/24] leon3: convert to memory API, Avi Kivity, 2011/08/24
[Qemu-devel] [PATCH 24/24] milkymist: convert to memory API, Avi Kivity, 2011/08/24
[Qemu-devel] [PATCH 15/24] Makefile.hw: allow hw/ files to include glib headers, Avi Kivity, 2011/08/24
[Qemu-devel] [PATCH 04/24] pci_host: convert conf index and data ports to memory API, Avi Kivity, 2011/08/24
[Qemu-devel] [PATCH 06/24] QEMUMachine: pass address space to machine init function, Avi Kivity, 2011/08/24
- Re: [Qemu-devel] [PATCH 06/24] QEMUMachine: pass address space to machine init function,
Peter Maydell <=
[Qemu-devel] [PATCH 16/24] pflash_cfi01/pflash_cfi02: convert to memory API, Avi Kivity, 2011/08/24
[Qemu-devel] [PATCH 22/24] milkymist-minimac2: convert to memory API, Avi Kivity, 2011/08/24