[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] vscsi: send the CHECK_CONDITION status down tog
From: |
David Gibson |
Subject: |
Re: [Qemu-devel] [PATCH] vscsi: send the CHECK_CONDITION status down together with autosense data |
Date: |
Thu, 25 Aug 2011 12:23:50 +1000 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Wed, Aug 24, 2011 at 04:41:34PM -0500, Alexander Graf wrote:
>
> On 24.08.2011, at 10:28, Paolo Bonzini wrote:
>
> > I introduced this bug in commit 05751d3 (vscsi: always use get_sense,
> > 2011-08-03) because at the time there was no way to expose a sense
> > condition to SLOF and Linux manages to work around the bug. However,
> > the bug becomes evident now that SCSI devices also report unit
> > attention on reset.
> >
> > SLOF also has problems dealing with unit attention conditions, so
> > it still will not boot even with this fix (just like OpenBIOS).
> > IBM folks are aware of their part of the bug. :-)
>
> David, please ack.
Done.
We also need to get the updated SLOF into place, I can't remember how
we sent commits involving binary blobs previously.
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson