[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v6 02/14] provide support for default implementa
From: |
Blue Swirl |
Subject: |
Re: [Qemu-devel] [PATCH v6 02/14] provide support for default implementations using weak symbols |
Date: |
Thu, 25 Aug 2011 17:40:51 +0000 |
On Thu, Aug 25, 2011 at 3:51 PM, Lluís <address@hidden> wrote:
> Routines using the QEMU_WEAK attribute can have a default implementation that
> can be later overriden just by re-implementing it.
Nack: weak attributes are only available for ELF and a.out.
> Signed-off-by: Lluís Vilanova <address@hidden>
> ---
> compiler.h | 13 ++++++++++++-
> 1 files changed, 12 insertions(+), 1 deletions(-)
>
> diff --git a/compiler.h b/compiler.h
> index 9af5dc6..bc06760 100644
> --- a/compiler.h
> +++ b/compiler.h
> @@ -12,7 +12,7 @@
> #define QEMU_WARN_UNUSED_RESULT
> #endif
>
> -#define QEMU_BUILD_BUG_ON(x) \
> +#define QEMU_BUILD_BUG_ON(x) \
> typedef char qemu_build_bug_on__##__LINE__[(x)?-1:1];
>
> #if defined __GNUC__
> @@ -31,4 +31,15 @@
> #define GCC_FMT_ATTR(n, m)
> #endif
>
> +/* Routine attribute to provide default (overridable) implementations.
> + *
> + * The code providing the default implementation must define
> QEMU_WEAK_DEFAULT
> + * before including this file.
> + */
> +#if !defined(QEMU_WEAK_DEFAULT)
> +#define QEMU_WEAK
> +#else
> +#define QEMU_WEAK __attribute__((weak))
> +#endif
> +
> #endif /* COMPILER_H */
>
>
>
- [Qemu-devel] [PATCH v6 00/14] trace-state: make the behaviour of "disable" consistent across all backends, Lluís, 2011/08/25
- [Qemu-devel] [PATCH v6 01/14] [simple] Include qemu-timer-common.o in trace-obj-y, Lluís, 2011/08/25
- [Qemu-devel] [PATCH v6 02/14] provide support for default implementations using weak symbols, Lluís, 2011/08/25
- Re: [Qemu-devel] [PATCH v6 02/14] provide support for default implementations using weak symbols,
Blue Swirl <=
- [Qemu-devel] [PATCH v6 03/14] trace: [configure] rename CONFIG_*_TRACE into CONFIG_TRACE_*, Lluís, 2011/08/25
- [Qemu-devel] [PATCH v6 04/14] trace: [make] replace 'ifeq' with values in CONFIG_TRACE_*, Lluís, 2011/08/25
- [Qemu-devel] [PATCH v6 05/14] trace: move backend-specific code into the trace/ directory, Lluís, 2011/08/25
- [Qemu-devel] [PATCH v6 06/14] trace: avoid conditional code compilation during option parsing, Lluís, 2011/08/25
- [Qemu-devel] [PATCH v6 07/14] trace: generalize the "property" concept in the trace-events file, Lluís, 2011/08/25
- [Qemu-devel] [PATCH v6 08/14] trace-state: separate trace event control and query routines from the simple backend, Lluís, 2011/08/25
- [Qemu-devel] [PATCH v6 10/14] trace-state: add "-trace events" argument to control initial state, Lluís, 2011/08/25
- [Qemu-devel] [PATCH v6 09/14] trace-state: always compile support for controlling and querying trace event states, Lluís, 2011/08/25
- [Qemu-devel] [PATCH v6 11/14] trace-state: always use the "nop" backend on events with the "disable" keyword, Lluís, 2011/08/25