Re: [Qemu-devel] [PATCH 1/6] target-alpha: Add custom PALcode image for CLIPPER emulation.

[Peter Maydell]

2011/8/25 Richard Henderson <address@hidden>:
> diff --git a/.gitmodules b/.gitmodules
> index 7884471..528743d 100644
> --- a/.gitmodules
> +++ b/.gitmodules
> @@ -10,3 +10,6 @@
>  [submodule "roms/ipxe"]
>        path = roms/ipxe
>        url = git://git.qemu.org/ipxe.git
> +[submodule "roms/qemu-palcode"]
> +       path = roms/qemu-palcode
> +       url = git://repo.or.cz/qemu-palcode.git

We had a conversation on IRC about binary blobs the other day,
and I think Anthony said that all submodules referred to here
had to also be on git.qemu.org. But I could be misremembering.
(In particular I thought Anthony said these were all relative
references, which they clearly aren't...)

> diff --git a/Makefile b/Makefile
> index 8606849..578d853 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -247,7 +247,8 @@ bamboo.dtb petalogix-s3adsp1800.dtb petalogix-ml605.dtb \
>  mpc8544ds.dtb \
>  multiboot.bin linuxboot.bin \
>  s390-zipl.rom \
> -spapr-rtas.bin slof.bin
> +spapr-rtas.bin slof.bin \
> +palcode-sx164
>  else
>  BLOBS=
>  endif

You don't update the list of blobs in the 'tarbin' target,
but I have a feeling that may be broken anyway. Does anybody
use it, and if not should we just nuke it?

> diff --git a/pc-bios/README b/pc-bios/README
> index f74b246..861227a 100644
> --- a/pc-bios/README
> +++ b/pc-bios/README
> @@ -32,3 +32,6 @@
>  - The S390 zipl loader is an addition to the official IBM s390-tools
>   package. That fork is maintained in its own git repository at:
>   git://repo.or.cz/s390-tools.git
> +
> +- The Alpha palcode image is available from:
> +  git://repo.or.cz/qemu-palcode.git

You mean "The Alpha palcode image sources"; the image will already
be in git :-)

-- PMM