[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] checkpatch: fix braces {} handling
From: |
Blue Swirl |
Subject: |
Re: [Qemu-devel] [PATCH] checkpatch: fix braces {} handling |
Date: |
Sat, 27 Aug 2011 17:53:33 +0000 |
Thanks, applied.
On Fri, Aug 26, 2011 at 1:34 PM, Pavel Borzenkov
<address@hidden> wrote:
> checkpatch.pl doesn't report warning for if/else statements with missing
> 'else' braces:
>
> if (something) {
> foo;
> } else
> bar;
>
> The patch has been tested using the last 100 commits.
>
> Signed-off-by: Pavel Borzenkov <address@hidden>
> ---
> scripts/checkpatch.pl | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> index 3498425..0eba357 100755
> --- a/scripts/checkpatch.pl
> +++ b/scripts/checkpatch.pl
> @@ -2532,7 +2532,7 @@ sub process {
> $allowed = 1;
> }
> }
> - if (!$seen) {
> + if ($seen != ($#chunks + 1)) {
> WARN("braces {} are necessary for all
> arms of this statement\n" . $herectx);
> }
> }
> --
> 1.7.0.4
>
>
>