Re: [Qemu-devel] softfloat breaks cocoa.m

[Alexander Graf]

On 28.08.2011, at 07:09, Andreas Färber wrote:

> Hello,
> 
> The unresolved softfloat uint* conversion business bites us again: This time, 
> the previously working Cocoa frontend stopped compiling:
> 
> In file included from /Users/andreas/QEMU/qemu/bswap.h:14,
>                 from /Users/andreas/QEMU/qemu/qemu-common.h:103,
>                 from /Users/andreas/QEMU/qemu/ui/cocoa.m:28:
> /Users/andreas/QEMU/qemu/fpu/softfloat.h:60: error: conflicting types for 
> ‘uint16’
> /System/Library/Frameworks/Security.framework/Headers/cssmconfig.h:68: error: 
> previous declaration of ‘uint16’ was here
> make: *** [ui/cocoa.o] Error 1
> 
> Since commit cbbab9226da9572346837466a8770c117e7e65a2 (move unaligned memory 
> access functions to bswap.h) softfloat.h is being #included in bswap.h, which 
> gets pulled into cocoa.m through qemu-common.h. I thought Alex had set up a 
> Darwin buildbot to catch such breakages...

No, that was only an idea so far. I don't have a spare Mac I could use for that 
atm :(.


> Any thoughts on how to proceed? My previous approach for Haiku, to replace 
> non-standard uint16 with POSIX uint_fast16_t etc., was rejected to avoid 
> system-dependent widths. I'd really like to get rid of the annoyingly 
> conflicting naming though (int vs. long for 32, int vs. short for 16, ...).

I'm not sure what you mean by system-dependent widths? This is only a naming 
collision issue, right? Can't we just name the types something more qemu 
specific?


Alex