[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1/2] Fix guest agent build with simpletrace
From: |
Lluís |
Subject: |
Re: [Qemu-devel] [PATCH 1/2] Fix guest agent build with simpletrace |
Date: |
Sun, 28 Aug 2011 20:13:58 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/23.3 (gnu/linux) |
Blue Swirl writes:
> On Sat, Aug 27, 2011 at 5:56 PM, Lluís <address@hidden> wrote:
>>>> I sent a patch that should fix it for everybody linking with the tracing
>>>> objects:
>>>>
>>>> http://lists.gnu.org/archive/html/qemu-devel/2011-08/msg03150.html
>>
>>> With your patch, there are warnings from linker:
>>> ../qemu-timer-common.o: warning: multiple common of `use_rt_clock'
>>> ../qemu-timer-common.o: warning: previous common is here
>>
>> Ah, yes. These extra errors are fixed by the duplicate elimination patch
>> :)
>>
>> http://lists.gnu.org/archive/html/qemu-devel/2011-08/msg02987.html
>>
>> So, you need both to keep it clean.
> Using the sort function looks hackish to me. Maybe the linkage should
> be controlled by configure instead?
What do you mean? Moving the logic for selecting the object files to
link with on each top-level target out into the configure?
In any case, I think that adding qemu-timer-common.o into trace-obj-y is
the cleanest way, as otherwise the object needs to be added again and
again depending on conditions that are checked multiple times, which I
think will lead to to makefile maintenance headaches in the long run.
Lluis
--
"And it's much the same thing with knowledge, for whenever you learn
something new, the whole world becomes that much richer."
-- The Princess of Pure Reason, as told by Norton Juster in The Phantom
Tollbooth
- [Qemu-devel] [PATCH 1/2] Fix guest agent build with simpletrace, Blue Swirl, 2011/08/26
- Re: [Qemu-devel] [PATCH 1/2] Fix guest agent build with simpletrace, Lluís, 2011/08/26
- Re: [Qemu-devel] [PATCH 1/2] Fix guest agent build with simpletrace, Blue Swirl, 2011/08/27
- Re: [Qemu-devel] [PATCH 1/2] Fix guest agent build with simpletrace, Lluís, 2011/08/27
- Re: [Qemu-devel] [PATCH 1/2] Fix guest agent build with simpletrace, Blue Swirl, 2011/08/28
- Re: [Qemu-devel] [PATCH 1/2] Fix guest agent build with simpletrace,
Lluís <=
- Re: [Qemu-devel] [PATCH 1/2] Fix guest agent build with simpletrace, Blue Swirl, 2011/08/28
- Re: [Qemu-devel] [PATCH 1/2] Fix guest agent build with simpletrace, Stefan Hajnoczi, 2011/08/29
- Re: [Qemu-devel] [PATCH 1/2] Fix guest agent build with simpletrace, Michael Roth, 2011/08/29
- [Qemu-devel] [PATCH] Add CONFIG_QEMU_TIMER to handle qemu-timer-common.o dep, Michael Roth, 2011/08/29
- Re: [Qemu-devel] [PATCH] Add CONFIG_QEMU_TIMER to handle qemu-timer-common.o dep, Stefan Hajnoczi, 2011/08/30
- Re: [Qemu-devel] [PATCH] Add CONFIG_QEMU_TIMER to handle qemu-timer-common.o dep, Lluís, 2011/08/30
- Re: [Qemu-devel] [PATCH] Add CONFIG_QEMU_TIMER to handle qemu-timer-common.o dep, Michael Roth, 2011/08/30
- Re: [Qemu-devel] [PATCH] Add CONFIG_QEMU_TIMER to handle qemu-timer-common.o dep, Lluís, 2011/08/30
- Re: [Qemu-devel] [PATCH] Add CONFIG_QEMU_TIMER to handle qemu-timer-common.o dep, Lluís, 2011/08/30
- Re: [Qemu-devel] [PATCH] Add CONFIG_QEMU_TIMER to handle qemu-timer-common.o dep, Anthony Liguori, 2011/08/30