qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] pflash_cfi01/pflash_cfi02: convert to memory AP


From: Avi Kivity
Subject: Re: [Qemu-devel] [PATCH] pflash_cfi01/pflash_cfi02: convert to memory API
Date: Mon, 29 Aug 2011 10:21:03 +0300
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:6.0) Gecko/20110816 Thunderbird/6.0

On 08/29/2011 09:15 AM, Avi Kivity wrote:
On 08/29/2011 09:00 AM, Edgar E. Iglesias wrote:
>
>  It does bite, as I saw with gdb.  You can even see that from the
>  qemu error - it complains about unimplemented command 0xf0, that
>  comes from pflash_write() later on.

I wasn't clear enough maybe, the code in question is running, but the
set_readble is not having any effect AFAICT. The reads, that
should come through via IO callbacks when switching mode are
not getting through. Do you ever see pflash_read beeing called?


Thanks for the clarification.  I don't, and there is now a fix on

  git://git.kernel.org/pub/scm/virt/kvm/qemu-kvm.git


Forgot the branch:

  git://git.kernel.org/pub/scm/virt/kvm/qemu-kvm.git  fix-pflash

--
I have a truly marvellous patch that fixes the bug which this
signature is too narrow to contain.




reply via email to

[Prev in Thread] Current Thread [Next in Thread]