[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1/2] Fix guest agent build with simpletrace
From: |
Lluís |
Subject: |
Re: [Qemu-devel] [PATCH 1/2] Fix guest agent build with simpletrace |
Date: |
Mon, 29 Aug 2011 14:47:22 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/23.3 (gnu/linux) |
Blue Swirl writes:
>>> Using the sort function looks hackish to me. Maybe the linkage should
>>> be controlled by configure instead?
>>
>> What do you mean? Moving the logic for selecting the object files to
>> link with on each top-level target out into the configure?
> Add CONFIG_QEMU_TIMER, configure sets it to 'y' when it is needed by
> simpletrace or other cases.
>> In any case, I think that adding qemu-timer-common.o into trace-obj-y is
>> the cleanest way, as otherwise the object needs to be added again and
>> again depending on conditions that are checked multiple times, which I
>> think will lead to to makefile maintenance headaches in the long run.
> That is not needed if the logic resides in configure:
> obj-$(CONFIG_QEMU_TIMER) += qemu-timer-common.o
Well, this looks more hackish than the 'sort' approach to me, but I can
live with that :)
Lluis
--
"And it's much the same thing with knowledge, for whenever you learn
something new, the whole world becomes that much richer."
-- The Princess of Pure Reason, as told by Norton Juster in The Phantom
Tollbooth
- Re: [Qemu-devel] [PATCH 1/2] Fix guest agent build with simpletrace, (continued)
- Re: [Qemu-devel] [PATCH 1/2] Fix guest agent build with simpletrace, Stefan Hajnoczi, 2011/08/29
- Re: [Qemu-devel] [PATCH 1/2] Fix guest agent build with simpletrace, Michael Roth, 2011/08/29
- [Qemu-devel] [PATCH] Add CONFIG_QEMU_TIMER to handle qemu-timer-common.o dep, Michael Roth, 2011/08/29
- Re: [Qemu-devel] [PATCH] Add CONFIG_QEMU_TIMER to handle qemu-timer-common.o dep, Stefan Hajnoczi, 2011/08/30
- Re: [Qemu-devel] [PATCH] Add CONFIG_QEMU_TIMER to handle qemu-timer-common.o dep, Lluís, 2011/08/30
- Re: [Qemu-devel] [PATCH] Add CONFIG_QEMU_TIMER to handle qemu-timer-common.o dep, Michael Roth, 2011/08/30
- Re: [Qemu-devel] [PATCH] Add CONFIG_QEMU_TIMER to handle qemu-timer-common.o dep, Lluís, 2011/08/30
- Re: [Qemu-devel] [PATCH] Add CONFIG_QEMU_TIMER to handle qemu-timer-common.o dep, Lluís, 2011/08/30
- Re: [Qemu-devel] [PATCH] Add CONFIG_QEMU_TIMER to handle qemu-timer-common.o dep, Anthony Liguori, 2011/08/30
- Re: [Qemu-devel] [PATCH] Add CONFIG_QEMU_TIMER to handle qemu-timer-common.o dep, Blue Swirl, 2011/08/30
- Re: [Qemu-devel] [PATCH 1/2] Fix guest agent build with simpletrace,
Lluís <=