Re: [Qemu-devel] [PATCH] qemu-ga: Fix linux build with trace backend

[Stefan Weil]

Am 29.08.2011 20:32, schrieb Lluís:
> Stefan Weil writes:
> > Builds with configure --enable-trace-backend=simple failed on linux
> > because qemu-ga then uses simpletrace.c which needs get_clock which
> > needs use_rt_clock which was unresolved.
> > Adding qemu-timer-common.o fixes this. It adds a little overhead
> > (about 150 byte).
>
> There are a couple of threads associated to this very same topic:
>
> http://lists.gnu.org/archive/html/qemu-devel/2011-08/msg02915.html
> http://lists.gnu.org/archive/html/qemu-devel/2011-08/msg03302.html
>
> Lluis

Thanks for the links. So we now have three patch sets for one problem,
and it will be fixed by a maintainer commit soon :-)

I personally prefer Blue Swirl's patch (which avoids the overhead)
or my own patch (which adds a little overhead but is the simplest
of all three patches). Sorting lists of object files and removing
duplicates looks strange in my opinion (and might also be bad when
related code no longer shares the same memory page).

With my patch, qemu-ga and the other tools (qemu-io, qemu-img, ...)
also use similar object lists.

Kind regards,
Stefan