Re: [Qemu-devel] [PATCH] Add CONFIG_QEMU_TIMER to handle qemu-timer-common.o dep

[Lluís]

Michael Roth writes:
> Hmm, looking again I'm confused why we need to do this in the first 
> place...the
> rule is:

> LINK = $(call quiet-command,$(CC) $(QEMU_CFLAGS) $(CFLAGS) $(LDFLAGS) -o 
> $@ $(1) $(LIBS),"  LINK  $(TARGET_DIR)$@")

> %$(EXESUF): %.o
>     $(call LINK,$^)

> According to the documentation $^ should remove duplicate dependencies, so I'm
> not getting why we need to de-dupe them once they get passed to LINK:

> http://www.gnu.org/software/make/manual/make.html#index-g_t_0024_005e-948

> Is there some distinction between duplicate dependencies and duplicate words 
> in
> the dependency list?

It does indeed work X'D

I was blindly searching for words like "duplicate" and "repeat" in
make's info page.

I just now realized that in my case, the duplication error appeared only
with targets defined in line 434 of Makefile.target.

The fix is as trivial as using this link line:

    $(call LINK,$^)


Nice catch Michael, we got lost in the discussion :)


Lluis

-- 
 "And it's much the same thing with knowledge, for whenever you learn
 something new, the whole world becomes that much richer."
 -- The Princess of Pure Reason, as told by Norton Juster in The Phantom
 Tollbooth