qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 2/2] omap_intc: Qdevify


From: Peter Maydell
Subject: Re: [Qemu-devel] [PATCH 2/2] omap_intc: Qdevify
Date: Wed, 31 Aug 2011 17:07:54 +0100

On 31 August 2011 16:55, Peter Maydell <address@hidden> wrote:
> Convert the omap_intc devices to qdev. This includes adding
> a 'revision' property which will be needed for omap3.

Incidentally this patch is a test case for a false positive in
checkpatch.pl, which complains:

ERROR: need consistent spacing around '*' (ctx:WxV)
#95: FILE: hw/omap.h:864:
+    DeviceState *ih[2];
                 ^

(it seems to be happy with 'struct DeviceState *ih[2];' and
'DeviceState *ih;' but not the combination of plain typename and
array member.)

-- PMM



reply via email to

[Prev in Thread] Current Thread [Next in Thread]