Re: [Qemu-devel] [PATCH v7 00/13] trace-state: make the behaviour of "disable" consistent across all backends

[Lluís]

Stefan Hajnoczi writes:

> On Thu, Aug 25, 2011 at 8:17 PM, Lluís <address@hidden> wrote:
>> This patch defines the "disable" trace event state to always use the "nop"
>> backend.
>> 
>> As a side-effect, all events are now enabled (without "disable") by default, 
>> as
>> all backends (except "stderr") have programmatic support for dynamically
>> (de)activating each trace event.
>> 
>> In order to make this true, the "simple" backend now has a "-trace
>> events=<file>" argument to let the user select which events must be enabled 
>> from
>> the very beginning.
>> 
>> NOTES:
>> * Parsing of -trace arguments is not done in the OS-specific frontends.
>> 
>> Signed-off-by: Lluís Vilanova <address@hidden>

> I have posted a few comments and build-tested the simple, stderr, and
> dtrace backends.  This is looking good, just a few small fixes.

Done. Sorry for the revision work I've been adding into you.


Lluis

-- 
 "And it's much the same thing with knowledge, for whenever you learn
 something new, the whole world becomes that much richer."
 -- The Princess of Pure Reason, as told by Norton Juster in The Phantom
 Tollbooth