Re: [Qemu-devel] [PATCH] Add support for r6040 NIC

[Blue Swirl]

On Wed, Aug 31, 2011 at 4:24 PM, malc <address@hidden> wrote:
> On Wed, 31 Aug 2011, Anthony Liguori wrote:
>
>> On 08/31/2011 09:35 AM, malc wrote:
>> > On Wed, 31 Aug 2011, Anthony Liguori wrote:
>> >
>> > > Upper case field names are not okay.  If you think coding style isn't
>> > > clear,
>> > > that's a bug in coding style.
>> >
>> > Sez hu? Coding style is garbage that should be thrown out of the window.
>> > As for looking, yeah, i'm looking at usb with it's lovely hungarian
>> > fields, should we stampede to "fix" it?
>> >
>> > If the one who's going to maintain the code is fine with whatever naming
>> > is used so be it.
>>
>> No.  That's how we got into the coding style mess we're in in the first
>> place.
>
> boblycat.org/~malc/right.ogg
>
>>
>> There's no benefit to going through and changing existing code but new code
>> needs to be consistent with the vast majority of code in the rest of the 
>> tree.
>> It's about overall code base consistency and maintainability.
>>
>
> Hand waving, for instance vast majority of the code never used the
> mandatory braces, the choice was arbitrary.

No, mandatory braces are better than the alternative. The choice has
been made and it has been mostly upheld.