Re: [Qemu-devel] [PATCH] Add support for r6040 NIC

[Blue Swirl]

On Wed, Aug 31, 2011 at 7:23 PM, Anthony Liguori <address@hidden> wrote:
> On 08/31/2011 02:12 PM, Edgar E. Iglesias wrote:
>>
>> On Wed, Aug 31, 2011 at 01:48:34PM -0500, Anthony Liguori wrote:
>>>>
>>>> etc, etc. IMO, those bring codingstyle issues into the pretty much
>>>> neglectable space.
>>>
>>> I don't think we lack contributors.  Documentation and tests are
>>> really about discipline.  If we can't even be bothered to maintain
>>> consistency in variable naming, do you really expected that we can
>>> be disciplined in writing documentation and tests?
>>
>> Yes I do. It's not white and black, it's not about making the code
>> completely inconsistent or 100 consistent. It's about find a level
>> of consistency that is acceptable and doesn't cost too much to
>> maintain.
>
> I actually agree.  I don't like the idea of absolutely enforcing a coding
> style that demands no white space at the end of a line (if you can't see it,
> why in the world would you care?).

Because then the patches for the line could be mangled by e-mail
transport. Actually git apply.whitespace=fix handles this nicely.

> But coding style deviations that make the code look foreign, like using
> CamelCase for field names, seems important to me.
>
> And I respect that other things seem important to other people (even
> invisible things like trailing white space).  So even though I wouldn't want
> to reject a patch because of coding style in some cases, I think it's
> important that we do our best to enforce it.

If the rules are enforced in some case but not in others, this is not
fair on submitters.