[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 37/45] block: Show whether the guest ejected
|
From: |
Kevin Wolf |
|
Subject: |
Re: [Qemu-devel] [PATCH v2 37/45] block: Show whether the guest ejected the medium in info block |
|
Date: |
Fri, 02 Sep 2011 15:04:19 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:6.0) Gecko/20110816 Thunderbird/6.0 |
Am 03.08.2011 15:08, schrieb Markus Armbruster:
> Need to ask the device, so this requires new BlockDevOps member
> is_medium_ejected().
>
> Signed-off-by: Markus Armbruster <address@hidden>
I find the name confusing. "medium is ejected" seems to mean "tray is
open". It isn't obvious that "tray is closed, but no medium is inserted"
is not "medium is ejected".
Why not call it tray_open like in the devices?
Kevin
- Re: [Qemu-devel] [PATCH v2 37/45] block: Show whether the guest ejected the medium in info block,
Kevin Wolf <=