Re: [Qemu-devel] [PATCH] qcow2: make cache=unsafe usable

[Avi Kivity]

On 09/07/2011 12:56 PM, Kevin Wolf wrote:
> Am 07.09.2011 11:24, schrieb Avi Kivity:
> >  Currently cache=unsafe is unsafe to the point of unusability - the
> >  caches are never written to disk except on exit so anything except
> >  an orderly exit -- including live migration -- leaves the disk image
> >  corrupted.
> >
> >  Fix by interpreting flush requests and doing everything except flushing
> >  the underlying file.  The contents of the metadata cache are transferred
> >  to the host pagecache, so that qemu aborts keep the disk in a consistent
> >  state, and live migration (on the same host, or if using a coherent
> >  filesystem) works.
> >
> >  Signed-off-by: Avi Kivity<address@hidden>
> >  ---
> >
> >  Untested - is this the right approach?
>
> Hm, could work, even though I don't like it very much. The alternative
> approach would be something like this

I think that your version is better - it fixes all the layered format 
drivers at once (even though qcow2 is the only one that needs fixing).

--
error compiling committee.c: too many arguments to function