[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] s390: remove boot image detection to fix boot w
|
From: |
Christian Borntraeger |
|
Subject: |
Re: [Qemu-devel] [PATCH] s390: remove boot image detection to fix boot with newer kernels |
|
Date: |
Wed, 07 Sep 2011 14:33:19 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.2.21) Gecko/20110831 Lightning/1.0b2 Thunderbird/3.1.13 |
On 07/09/11 13:56, Alexander Graf wrote:
>
> On 06.09.2011, at 13:41, Christian Borntraeger wrote:
>
>> Alex,
>>
>> Newer kernels will not always have a 0dd0 (basr 13,0) at address 0x10000.
>> (e.g. current linux-next). We must not rely on specific code at certain
>> addresses, so lets just remove this check.
>
> Is there any other sane way we can find out if the image we're loading is
> actually bootable? I don't want users to do qemu-system-s390x -kernel
> vmlinux and see it just plain fail.
No, in theory it could change arbitrarily. The vmlinux case is unfortunate
but in the end its "shoot yourself in the foot", we just have to make sure
that we allow a graceful exit from a looping qemu guest.
Christian