[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1/5] dma-helpers: rename is_write to to_dev
From: |
Kevin Wolf |
Subject: |
Re: [Qemu-devel] [PATCH 1/5] dma-helpers: rename is_write to to_dev |
Date: |
Fri, 09 Sep 2011 13:31:27 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:6.0) Gecko/20110816 Thunderbird/6.0 |
Am 07.09.2011 17:20, schrieb Paolo Bonzini:
> Signed-off-by: Paolo Bonzini <address@hidden>
> ---
> dma-helpers.c | 10 +++++-----
> 1 files changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/dma-helpers.c b/dma-helpers.c
> index 4610ea0..ca97e14 100644
> --- a/dma-helpers.c
> +++ b/dma-helpers.c
> @@ -42,7 +42,7 @@ typedef struct {
> BlockDriverAIOCB *acb;
> QEMUSGList *sg;
> uint64_t sector_num;
> - int is_write;
> + int to_dev;
> int sg_cur_index;
> target_phys_addr_t sg_cur_byte;
> QEMUIOVector iov;
Should we take the opportunity to make it a bool? I think it would make
the purpose easier to understand.
Kevin
- [Qemu-devel] [PATCH 0/5] block: preparatory patches for scatter/gather support, Paolo Bonzini, 2011/09/07
- [Qemu-devel] [PATCH 4/5] scsi-disk: commonize iovec creation between reads and writes, Paolo Bonzini, 2011/09/07
- [Qemu-devel] [PATCH 5/5] scsi-disk: lazily allocate bounce buffer, Paolo Bonzini, 2011/09/07
- [Qemu-devel] [PATCH 2/5] dma-helpers: allow including from target-independent code, Paolo Bonzini, 2011/09/07
- [Qemu-devel] [PATCH 1/5] dma-helpers: rename is_write to to_dev, Paolo Bonzini, 2011/09/07
- Re: [Qemu-devel] [PATCH 1/5] dma-helpers: rename is_write to to_dev,
Kevin Wolf <=
- [Qemu-devel] [PATCH 3/5] dma-helpers: rewrite completion/cancellation, Paolo Bonzini, 2011/09/07
- Re: [Qemu-devel] [PATCH 3/5] dma-helpers: rewrite completion/cancellation, Kevin Wolf, 2011/09/09
- Re: [Qemu-devel] [PATCH 3/5] dma-helpers: rewrite completion/cancellation, Paolo Bonzini, 2011/09/09
- Re: [Qemu-devel] [PATCH 3/5] dma-helpers: rewrite completion/cancellation, Kevin Wolf, 2011/09/09
- Re: [Qemu-devel] [PATCH 3/5] dma-helpers: rewrite completion/cancellation, Paolo Bonzini, 2011/09/09
- Re: [Qemu-devel] [PATCH 3/5] dma-helpers: rewrite completion/cancellation, Kevin Wolf, 2011/09/09
- Re: [Qemu-devel] [PATCH 3/5] dma-helpers: rewrite completion/cancellation, Paolo Bonzini, 2011/09/09