|
| From: | Avi Kivity |
| Subject: | Re: [Qemu-devel] [PATCH v3 5/6] vga: Use linear mapping + dirty logging in chain 4 memory access mode |
| Date: | Tue, 13 Sep 2011 11:10:05 +0300 |
| User-agent: | Mozilla/5.0 (X11; Linux i686 on x86_64; rv:6.0.2) Gecko/20110906 Thunderbird/6.0.2 |
On 09/13/2011 10:54 AM, Alexander Graf wrote:
>> >> Yeah, usually the ISA bus is behind an ISA-PCI bridge, so it should inherit the offset from its parent. Or do you mean something different? >> > > He means that isa_mem_base should go away; instead isa_address_space() should be a subregion at offset 0x80000000. So we are talking about the same thing. Logically speaking, ISA devices are behind the ISA-PCI bridge, so the parent would be the bridge, right?
Right. system_memory -> pci_address_space() -> isa_address_space() -> various vga areas.
> Which vga variant are you using? This is stdvga.
Don't see the call to vga_init() in that path (this is what passes isa_address_space() to the vga core).
-- I have a truly marvellous patch that fixes the bug which this signature is too narrow to contain.
| [Prev in Thread] | Current Thread | [Next in Thread] |