Re: [Qemu-devel] [PATCH v2 09/12] sheepdog: move coroutine send/recv function to generic code

[Paolo Bonzini]

On 09/13/2011 04:14 PM, Kevin Wolf wrote:
> > >    block/sheepdog.c |  225 
> > ++++++------------------------------------------------
> > >    cutils.c         |  103 +++++++++++++++++++++++++
> > >    qemu-common.h    |    3 +
> > >    qemu-coroutine.c |   70 +++++++++++++++++
> > >    qemu-coroutine.h |   26 ++++++
>
> Can we move the code somewhere else? This is not core coroutine
> infrastructure. I would suggest qemu_socket.h/qemu-sockets.c.

It's not really socket-specific either (it uses recv/send only because 
of Windows brokenness---it could use read/write if it wasn't for that). 
 I hoped sooner or later it could become a qemu_co_readv/writev, hence 
the choice of qemu-coroutine.c.

Paolo

ps: I also hope that the Earth will start spinning slower and will give 
me 32 hour days, so just tell me if you really want that outside 
qemu-coroutine.c.