Re: [Qemu-devel] [PATCH 00/12] nbd improvements

[Kevin Wolf]

Am 08.09.2011 17:24, schrieb Paolo Bonzini:
> I find nbd quite useful to test migration, but it is limited:
> it can only do synchronous operation, it is not safe because it
> does not support flush, and it has no discard either.  qemu-nbd
> is also limited to 1MB requests, and the nbd block driver does
> not take this into account.
> 
> Luckily, flush/FUA support is being worked out by upstream,
> and discard can also be added with the same framework (patches
> 1 to 6).
> 
> Asynchronous support is also very similar to what sheepdog is
> already doing (patches 7 to 12).
> 
> Paolo Bonzini (12):
>   nbd: support feature negotiation
>   nbd: sync API definitions with upstream
>   nbd: support NBD_SET_FLAGS ioctl
>   nbd: add support for NBD_CMD_FLUSH
>   nbd: add support for NBD_CMD_FLAG_FUA
>   nbd: support NBD_CMD_TRIM in the server
>   sheepdog: add coroutine_fn markers
>   add socket_set_block
>   sheepdog: move coroutine send/recv function to generic code
>   block: add bdrv_co_flush support
>   nbd: switch to asynchronous operation
>   nbd: split requests

Okay, completed the review for this series now. I think if you consider
the comments posted so far for v2 we should be good.

Kevin