[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] tcg/arm: Remove unused tcg_out_addi()
From: |
Richard Henderson |
Subject: |
Re: [Qemu-devel] [PATCH] tcg/arm: Remove unused tcg_out_addi() |
Date: |
Wed, 14 Sep 2011 12:34:36 -0700 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:6.0.2) Gecko/20110906 Thunderbird/6.0.2 |
On 09/12/2011 03:03 AM, Peter Maydell wrote:
> Remove the unused function tcg_out_addi() from the ARM TCG backend;
> this fixes a compilation failure on ARM hosts with newer gcc.
>
> Signed-off-by: Peter Maydell <address@hidden>
Reviewed-by: Richard Henderson <address@hidden>
> ---
> A previous patch from Richard Henderson for this compile failure:
> http://patchwork.ozlabs.org/patch/110400/
> was rejected, so here's another go. This simply removes the unused function,
> in line with the approach taken for ppc/ppc64 in commits 1a2eb162414 and
> c24a9c6ef94.
>
> If this is accepted I can do the equivalent patches for tcg/ia64 and tcg/s390
> (although those don't cause compile failures because the unused function
> happens to be marked 'inline'.)
If we ever need this function again, we can revive it from git.
I'm in favor of deleting all of these functions.
r~