qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 00/14] qdev: assign unique names to all devices


From: Anthony Liguori
Subject: Re: [Qemu-devel] [PATCH 00/14] qdev: assign unique names to all devices (part 1)
Date: Fri, 16 Sep 2011 11:22:15 -0500
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.17) Gecko/20110516 Lightning/1.0b2 Thunderbird/3.1.10

On 09/16/2011 11:00 AM, Anthony Liguori wrote:
This series introduces an infrastructure to remove anonymous devices from qdev.
Anonymous devices are one of the big gaps between qdev and QOM so removing is
a prerequisite to incrementally merging QOM.

Besides the infrastructure, I also converted almost all of the possible PC
devices to have unique names.  Please not that naming is not a property of
devices but rather of the thing that creates the devices (usually machines).

The names are ugly but this is because of the alternating device/bus hierarchy
in qdev.  For now, the names use '::' as deliminators but I think Jan has
convinced me that down the road, we should use '/' as a deliminator such that
the resulting names are actually valid paths (using a canonical path format).



Here's a diffstat:

 apb_pci.c                  |    2
 apic.c                     |    2
 arm11mpcore.c              |    4 -
 arm_sysctl.c               |    2
 armv7m.c                   |    6 +-
 axis_dev88.c               |    8 +--
 bonito.c                   |    2
 collie.c                   |    2
 cs4231a.c                  |    2
 empty_slot.c               |    2
 escc.c                     |    4 -
 esp.c                      |    2
 etraxfs.h                  |    2
 fdc.c                      |    4 -
 fdc.h                      |    2
 fw_cfg.c                   |    2
 grackle_pci.c              |    2
 grlib.h                    |    6 +-
 gt64xxx.c                  |    2
 gus.c                      |    2
 i2c.c                      |    2
 ide/isa.c                  |    2
 ide/qdev.c                 |    3 -
 integratorcp.c             |   21 +++++-----
 intel-hda.c                |    2
 isa-bus.c                  |   32 +++++++++++----
 isa.h                      |    9 ++--
 kvmclock.c                 |    2
 lan9118.c                  |    2
 lm32.h                     |    4 -
 lm32_boards.c              |   14 +++---
 m48t59.c                   |    4 -
 mainstone.c                |    2
 mc146818rtc.c              |    2
 milkymist-hw.h             |   22 +++++-----
 mips_fulong2e.c            |    2
 mips_jazz.c                |    4 -
 mips_malta.c               |    2
 mips_mipssim.c             |    2
 mips_r4k.c                 |    2
 musicpal.c                 |   21 +++++-----
 nand.c                     |    2
 nseries.c                  |    4 -
 omap1.c                    |    2
 omap2.c                    |    2
 pc.c                       |   15 +++----
 pc.h                       |   12 ++---
 pc_piix.c                  |    8 ++-
 pci.c                      |   35 +++++++++++-----
 petalogix_s3adsp1800_mmu.c |    2
 piix_pci.c                 |    2
 ppc_prep.c                 |    2
 ppce500_mpc8544ds.c        |    4 -
 pxa2xx.c                   |   24 +++++++----
 pxa2xx_dma.c               |    4 -
 pxa2xx_gpio.c              |    2
 pxa2xx_pic.c               |    2
 qdev.c                     |   94 +++++++++++++++++++++++++++++++++++++++------
 qdev.h                     |   11 +++--
 r2d.c                      |    4 -
 realview.c                 |   40 +++++++++----------
 s390-virtio-bus.c          |    2
 s390-virtio.c              |    4 -
 sb16.c                     |    2
 scsi-bus.c                 |    2
 sm501.c                    |    2
 smbus_eeprom.c             |    3 -
 smc91c111.c                |    2
 spapr_llan.c               |    2
 spapr_vio.c                |    2
 spapr_vscsi.c              |    2
 spapr_vty.c                |    2
 spitz.c                    |    8 +--
 ssi.c                      |    2
 stellaris.c                |   14 +++---
 strongarm.c                |   17 ++++----
 sun4m.c                    |   32 +++++++--------
 sun4u.c                    |    6 +-
 syborg.c                   |   22 +++++-----
 sysbus.c                   |   67 +++++++++++++++++++++++++++++---
 sysbus.h                   |   31 ++++++++------
 tosa.c                     |    4 -
 unin_pci.c                 |    8 +--
 usb-bus.c                  |    2
 versatilepb.c              |   34 ++++++++--------
 vexpress.c                 |   28 ++++++-------
 xilinx.h                   |   10 ++--
 87 files changed, 490 insertions(+), 307 deletions(-)

Regards,

Anthony Liguori



reply via email to

[Prev in Thread] Current Thread [Next in Thread]