[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 04/15] coroutine-io: handle zero returns from
From: |
MORITA Kazutaka |
Subject: |
Re: [Qemu-devel] [PATCH v2 04/15] coroutine-io: handle zero returns from recv |
Date: |
Sat, 17 Sep 2011 15:50:45 +0900 |
User-agent: |
Wanderlust/2.14.0 (Africa) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (Gojō) APEL/10.8 Emacs/22.3 (x86_64-pc-linux-gnu) MULE/5.0 (SAKAKI) |
At Fri, 16 Sep 2011 16:25:41 +0200,
Paolo Bonzini wrote:
>
> When the other side is shutdown, read returns zero (writes return EPIPE).
> In this case, care must be taken to avoid infinite loops. This error
> was already present in sheepdog.
>
> Cc: MORITA Kazutaka <address@hidden>
> Signed-off-by: Paolo Bonzini <address@hidden>
> ---
> cutils.c | 8 +++++++-
> 1 files changed, 7 insertions(+), 1 deletions(-)
>
> diff --git a/cutils.c b/cutils.c
> index b302020..295187f 100644
> --- a/cutils.c
> +++ b/cutils.c
> @@ -501,8 +501,11 @@ static int do_sendv_recvv(int sockfd, struct iovec *iov,
> int len, int offset,
> }
> break;
> }
> - iovlen--, p++;
> + if (rc == 0) {
> + break;
> + }
> ret += rc;
> + iovlen--, p++;
> }
> #endif
> }
> @@ -567,6 +570,9 @@ int coroutine_fn qemu_co_sendv(int sockfd, struct iovec
> *iov,
> }
> break;
> }
> + if (ret == 0) {
> + break;
> + }
> total += ret, len -= ret;
> }
When EPIPE is set, write() returns -1 doesn't it?
It looks like qemu_co_recvv() handles a zero return correctly, so I
think this patch is not needed.
Thanks,
Kazutaka
- Re: [Qemu-devel] [PATCH v2 01/15] sheepdog: add coroutine_fn markers, (continued)
[Qemu-devel] [PATCH v2 04/15] coroutine-io: handle zero returns from recv, Paolo Bonzini, 2011/09/16
- Re: [Qemu-devel] [PATCH v2 04/15] coroutine-io: handle zero returns from recv,
MORITA Kazutaka <=
[Qemu-devel] [PATCH v2 05/15] block: emulate .bdrv_flush() using .bdrv_aio_flush(), Paolo Bonzini, 2011/09/16
[Qemu-devel] [PATCH v2 06/15] block: group together the plugging of synchronous IO emulation, Paolo Bonzini, 2011/09/16
[Qemu-devel] [PATCH v2 12/15] nbd: add support for NBD_CMD_TRIM, Paolo Bonzini, 2011/09/16
[Qemu-devel] [PATCH v2 09/15] nbd: fix error handling in the server, Paolo Bonzini, 2011/09/16
[Qemu-devel] [PATCH v2 10/15] nbd: add support for NBD_CMD_FLUSH, Paolo Bonzini, 2011/09/16
[Qemu-devel] [PATCH v2 08/15] block: add bdrv_co_discard and bdrv_aio_discard support, Paolo Bonzini, 2011/09/16
[Qemu-devel] [PATCH v2 07/15] block: add bdrv_co_flush support, Paolo Bonzini, 2011/09/16
[Qemu-devel] [PATCH v2 14/15] nbd: split requests, Paolo Bonzini, 2011/09/16
[Qemu-devel] [PATCH v2 11/15] nbd: add support for NBD_CMD_FLAG_FUA, Paolo Bonzini, 2011/09/16
[Qemu-devel] [PATCH v2 13/15] nbd: switch to asynchronous operation, Paolo Bonzini, 2011/09/16