qemu-devel
[Top][All Lists]
Advanced
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 1/2] memory: Fix old portio word accesses

From: Richard Henderson
Subject: Re: [Qemu-devel] [PATCH 1/2] memory: Fix old portio word accesses
Date: Sun, 18 Sep 2011 07:44:56 -0700
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.22) Gecko/20110906 Fedora/3.1.14-1.fc14 Thunderbird/3.1.14 
On 09/18/2011 05:44 AM, Jan Kiszka wrote:
> +            *data = mrp->read(mr->opaque, offset + mr->offset) |
> +                    mrp->read(mr->opaque, offset + mr->offset + 1);

Missing shift.

Also, a comment about the fact that the legacy interface doesn't
handle size 4 would also be welcome.


r~
reply via email to
[Prev in Thread] Current Thread [Next in Thread]